-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few typos in docstrings #695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the spell lint :) just one minor change is required. Could you fix this?
scripts/build_natura_raster.py
Outdated
@@ -116,7 +116,7 @@ def get_transform_and_shape(bounds, res, out_logging): | |||
|
|||
def unify_protected_shape_areas(inputs, natura_crs, out_logging): | |||
""" | |||
Iterates thorugh all snakemake rule inputs and unifies shapefiles (.shp) only. | |||
Iterates thorough all snakemake rule inputs and unifies shapefiles (.shp) only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be through
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sorry. I'll fix it in a moment.
@pitmonticone Could you also please confirm here that this contribution can be relicensed to AGPL in case the community decides so? |
Ops, sorry. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Confirmed in the discussion thread with 🏆. Thanks. |
Welcome as contributor @pitmonticone 🥇 |
Thank you very much @pz-max for the development and maintenance of all these great open-source research-quality packages! Let me know if you believe it could be helpful if I join this GitHub organisation as a member. Happy to help when I find the time. |
@pitmonticone, thanks for the offer. It probably just makes sense to make you a org. member in case you prove to be a long-term contributor. But sure, we will inform you if it makes sense otherwise 👍 |
It sounds right to me. Thanks a lot for the quick review and merge. |
Changes proposed in this Pull Request
I've just fixed a few typo in docstrings and comments.
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.